Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16731: fix task feed card not opening in right panel after click #16738

Merged
merged 7 commits into from
Jun 26, 2024
Merged

#16731: fix task feed card not opening in right panel after click #16738

merged 7 commits into from
Jun 26, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #16731

  • I worked on fixing task feed card not opening in right panel after click
Screen.Recording.2024-06-20.at.4.30.00.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jun 20, 2024
@Ashish8689 Ashish8689 self-assigned this Jun 20, 2024
@github-actions github-actions bot added e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs labels Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.22% (35321/54158) 42% (13975/33274) 44.01% (4338/9856)

@Ashish8689 Ashish8689 marked this pull request as ready for review June 25, 2024 07:45
@cypress Cypress
Copy link

cypress bot commented Jun 25, 2024 •
edited
Loading

Passing run #34511 ↗︎

0 78 262 0 Flakiness 0

Details:

Merge branch 'main' into task-feed-card-fix
Project: openmetadata Commit: 116c5a61be
Status: Passed Duration: 09:14 💡
Started: Jun 26, 2024 10:13 AM Ended: Jun 26, 2024 10:22 AM

Review all test suite changes for PR #16738 ↗︎

ShaileshParmar11
ShaileshParmar11 reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts Outdated Show resolved Hide resolved
@Ashish8689
Copy link
Contributor Author

@chirag-madlani changes made as per comments!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ulixius9 ulixius9 merged commit 3019ea3 into main Jun 26, 2024
16 checks passed
@ulixius9 ulixius9 deleted the task-feed-card-fix branch June 26, 2024 11:32
harshach pushed a commit that referenced this pull request Jun 30, 2024
@Ashish8689 @harshach
#16731: fix task feed card not opening in right panel after click (#1…
d937839 
…6738)

* fix task feed card not opening in right panel after click

* added playwright test

* changes as per comments

* changes as per comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task card details are not opening in right panel after click
4 participants
@Ashish8689 @chirag-madlani @ShaileshParmar11 @ulixius9