Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: raise lineage error when table does not exist #16756

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Jun 21, 2024

Describe your changes:

When lineage ingestion fails due to missing tables, it is not captured by the workflow. This change changes that to capture missing table errors and report them to the user. This is important because it might result in:

  1. user error of choosing the wrong query log or service.
  2. error with the query parser.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner June 21, 2024 08:42
@sushi30 sushi30 changed the title raise lineage error when table does not exist MINOR: raise lineage error when table does not exist Jun 21, 2024
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jun 21, 2024
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

IceS2
IceS2 previously approved these changes Jun 21, 2024
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

ulixius9
ulixius9 previously approved these changes Jun 22, 2024
Copy link

sonarcloud bot commented Jun 24, 2024

@sushi30 sushi30 requested review from ulixius9 and IceS2 June 24, 2024 14:42
@sushi30 sushi30 enabled auto-merge (squash) June 24, 2024 15:26
@sushi30 sushi30 merged commit 54ca82f into main Jun 24, 2024
13 checks passed
@sushi30 sushi30 deleted the raise-for-missing-tables-lineage branch June 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants