Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in work_dir. #110

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Fix bug in work_dir. #110

merged 2 commits into from
Aug 12, 2020

Conversation

SuX97
Copy link
Collaborator

@SuX97 SuX97 commented Aug 12, 2020

The args.work_dir will never be None, it will only be '' an empty str. When training without specific work_dir, it results in lots of logs and ckpts saved in $MMACTION2_HOME.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files          76       76           
  Lines        4136     4136           
  Branches      661      661           
=======================================
  Hits         3535     3535           
  Misses        494      494           
  Partials      107      107           
Flag Coverage Δ
#unittests 85.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886a6cf...f1f655c. Read the comment docs.

@innerlee
Copy link
Contributor

image

@SuX97
Copy link
Collaborator Author

SuX97 commented Aug 12, 2020

But in slurm_train.sh, it will be
image. @innerlee

@innerlee
Copy link
Contributor

that is a bug of slurm_train.sh

Copy link
Collaborator

@dreamerlin dreamerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If we modify line69, line22 should also be changed by setting default value.
  2. Otherwise, we could also modify the slurm script.

@innerlee
Copy link
Contributor

2

@SuX97
Copy link
Collaborator Author

SuX97 commented Aug 12, 2020

I vote for change the slurm scripts, just remove the work_dir to PY_ARGS as the user wishes. @dreamerlin

@dreamerlin
Copy link
Collaborator

Well, we can try plan 2 to see what will happen.

@innerlee
Copy link
Contributor

Another choice: abandon slurm_train.sh and adopt slurm_train

@innerlee innerlee merged commit 6671d27 into open-mmlab:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants