-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in work_dir. #110
Fix bug in work_dir. #110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 76 76
Lines 4136 4136
Branches 661 661
=======================================
Hits 3535 3535
Misses 494 494
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
But in |
that is a bug of slurm_train.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If we modify line69, line22 should also be changed by setting default value.
- Otherwise, we could also modify the slurm script.
2 |
I vote for change the slurm scripts, just remove the work_dir to PY_ARGS as the user wishes. @dreamerlin |
Well, we can try plan 2 to see what will happen. |
Another choice: abandon |
The
args.work_dir
will never be None, it will only be''
an empty str. When training without specific work_dir, it results in lots of logs and ckpts saved in $MMACTION2_HOME.