Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify 'val_step()' to validate data for each val mode epoch #123

Merged
merged 4 commits into from
Aug 22, 2020

Conversation

dreamerlin
Copy link
Collaborator

An alternative validation process pointed out by #115, but we still suggest using --validate to call EvalHook and DistEvalHook for evaluation.
Related modification in mmcv is also submitted

@dreamerlin dreamerlin added the WIP work in progress label Aug 14, 2020
@innerlee innerlee requested a review from hellock August 14, 2020 12:09
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #123 into master will decrease coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   85.53%   85.51%   -0.02%     
==========================================
  Files          76       76              
  Lines        4155     4157       +2     
  Branches      662      662              
==========================================
+ Hits         3554     3555       +1     
- Misses        494      496       +2     
+ Partials      107      106       -1     
Flag Coverage Δ
#unittests 85.51% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/backbones/resnet_tsm.py 95.08% <ø> (ø)
mmaction/models/recognizers/base.py 59.72% <0.00%> (-1.71%) ⬇️
mmaction/models/backbones/resnet3d_csn.py 100.00% <100.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f0aac...84d1acc. Read the comment docs.

@dreamerlin dreamerlin removed the WIP work in progress label Aug 14, 2020
@dreamerlin dreamerlin changed the title Modify 'val_step()' to validate data for each iter Modify 'val_step()' to validate data for each val mode epoch Aug 14, 2020
@innerlee innerlee merged commit f1f206c into open-mmlab:master Aug 22, 2020
@dreamerlin dreamerlin deleted the val_mode branch September 1, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants