Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the structure of tools directory and rename some scripts #142

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

dreamerlin
Copy link
Collaborator

@dreamerlin dreamerlin commented Aug 22, 2020

This PR adjusts the tools directory structure and rename some scripts files.

  1. anet_feature_prepare.py -> activitynet_feature_extraction.py, gen_flow.py -> flow_extraction.py, tsn_feature_extract.py -> tsn_feature_extraction.py
  2. Create tools/analysis directory and put analyze_logs.py, bench_processing.py, benchmark.py, get_flops.py and report_accuracy.py into it.
  3. Put activitynet_feature_extraction.py and tsn_feature_extraction.py in tools/data/activitynet
  4. Update the docs.

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   84.21%   84.21%           
=======================================
  Files          73       73           
  Lines        4175     4175           
  Branches      638      638           
=======================================
  Hits         3516     3516           
  Misses        554      554           
  Partials      105      105           
Flag Coverage Δ
#unittests 84.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/recognizers/recognizer2d.py 78.57% <ø> (ø)
mmaction/models/recognizers/recognizer3d.py 81.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea73520...60d0e82. Read the comment docs.

@innerlee
Copy link
Contributor

innerlee commented Aug 23, 2020

the term generation is no better than extraction. generation is an ML task such as GAN, while extraction is a technical operation for feature extraction.

edit: feature_preparation is more accurate than extraction, what do u think? also, they belong to the tools/data right?

@dreamerlin
Copy link
Collaborator Author

the term generation is no better than extraction. generation is an ML task such as GAN, while extraction is a technical operation for feature extraction.

edit: feature_preparation is more accurate than extraction, what do u think? also, they belong to the tools/data right?

generation -> extraction. Move activitynet_feature_extraction.py to tools/data/activitynet

@innerlee innerlee merged commit a3da16f into open-mmlab:master Aug 28, 2020
@dreamerlin dreamerlin deleted the adjust_tools branch September 1, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants