Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support TAM [WIP] #304

Closed
wants to merge 8 commits into from
Closed

Conversation

congee524
Copy link
Contributor

No description provided.

@congee524 congee524 changed the title [Feature] Support TAM [Feature] Support TAM [WIP] Nov 1, 2020
@dreamerlin dreamerlin marked this pull request as draft November 1, 2020 10:41
@dreamerlin dreamerlin mentioned this pull request Nov 1, 2020
14 tasks
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #304 (b751a06) into master (9c71443) will increase coverage by 0.35%.
The diff coverage is 72.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   85.05%   85.41%   +0.35%     
==========================================
  Files          88      100      +12     
  Lines        5994     7019    +1025     
  Branches      983     1131     +148     
==========================================
+ Hits         5098     5995     +897     
- Misses        709      807      +98     
- Partials      187      217      +30     
Flag Coverage Δ
unittests 85.39% <72.57%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/apis/inference.py 81.81% <ø> (ø)
mmaction/datasets/audio_dataset.py 73.68% <ø> (-10.10%) ⬇️
mmaction/datasets/audio_feature_dataset.py 73.68% <ø> (-10.10%) ⬇️
mmaction/datasets/video_dataset.py 66.66% <ø> (-15.88%) ⬇️
mmaction/localization/proposal_utils.py 100.00% <ø> (ø)
mmaction/localization/ssn_utils.py 100.00% <ø> (ø)
mmaction/models/backbones/c3d.py 91.89% <ø> (ø)
mmaction/models/backbones/resnet.py 94.83% <ø> (ø)
mmaction/models/backbones/resnet3d_slowfast.py 87.97% <ø> (ø)
mmaction/models/backbones/resnet3d_slowonly.py 100.00% <ø> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c71443...8b7c533. Read the comment docs.

def __init__(self, block, num_segments, tam_cfg=None):
super().__init__()
if tam_cfg is None:
tam_cfg = dict()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the mutable value can be set as default values, as long as you use copy.deepcopy() to protect it. The method is also approved by @innerlee

@dreamerlin dreamerlin mentioned this pull request Dec 2, 2020
15 tasks
@congee524 congee524 closed this Dec 11, 2020
@dreamerlin dreamerlin mentioned this pull request Jan 11, 2021
6 tasks
@dreamerlin dreamerlin mentioned this pull request Feb 25, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants