Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Resnet2dAudio #355

Merged
merged 16 commits into from
Nov 30, 2020
Merged

[Feature] Add Resnet2dAudio #355

merged 16 commits into from
Nov 30, 2020

Conversation

SuX97
Copy link
Collaborator

@SuX97 SuX97 commented Nov 18, 2020 •
edited
Loading

This PR adds

  • code and config AudioOnly Pathway for AVSlowFast and its checkpoint
  • code and config for AVSlowfast backbone

@codecov
Copy link

codecov bot commented Nov 20, 2020 •
edited
Loading

Codecov Report

Merging #355 (6cf39d8) into master (d52d775) will increase coverage by 0.26%.
The diff coverage is 84.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   86.30%   86.56%   +0.26%     
==========================================
  Files          98      101       +3     
  Lines        6921     7168     +247     
  Branches     1118     1158      +40     
==========================================
+ Hits         5973     6205     +232     
- Misses        730      731       +1     
- Partials      218      232      +14
Flag Coverage Δ
unittests 86.55% <84.69%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/apis/train.py 15.00% <ø> (ø)
mmaction/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmaction/models/common/conv2plus1d.py 100.00% <ø> (ø)
mmaction/models/recognizers/base.py 60.78% <ø> (+1.96%) ⬆️
mmaction/datasets/audio_visual_dataset.py 76.74% <76.74%> (ø)
mmaction/models/backbones/resnet_audio.py 81.15% <81.15%> (ø)
mmaction/datasets/pipelines/loading.py 89.97% <83.01%> (+3.85%) ⬆️
mmaction/__init__.py 100.00% <100.00%> (ø)
mmaction/apis/test.py 72.72% <100.00%> (+0.63%) ⬆️
mmaction/datasets/__init__.py 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52d775...d2d2057. Read the comment docs.

@SuX97 SuX97 force-pushed the audio_resnet branch 5 times, most recently from 522911b to 8b4b529 Compare November 25, 2020 11:59
Fix code style according to review.
b88e588 
Minor.

Fix bugs in unittest.=

Minor adding.
@SuX97 SuX97 force-pushed the audio_resnet branch 2 times, most recently from 82a33b9 to 1726cbe Compare November 25, 2020 13:00
@SuX97 SuX97 force-pushed the audio_resnet branch 2 times, most recently from 72a545b to 55458bf Compare November 27, 2020 07:59
@SuX97
Copy link
Collaborator Author

SuX97 commented Nov 27, 2020

@innerlee Kindly ping, this PR is ready to go.

@SuX97 SuX97 requested a review from innerlee November 27, 2020 08:58
@innerlee innerlee merged commit cd46a1b into open-mmlab:master Nov 30, 2020
This was referenced Dec 1, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamerlin dreamerlin dreamerlin left review comments

@innerlee innerlee innerlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuX97 @innerlee @dreamerlin