Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unittest on repr for LoadHVULabel and SampleFrames in loading.py #358

Merged
merged 2 commits into from
Nov 27, 2020

Conversation

congee524
Copy link
Contributor

@congee524 congee524 commented Nov 18, 2020

add repr unittest

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #358 (6434c62) into master (25b88f1) will increase coverage by 0.37%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   86.20%   86.58%   +0.37%     
==========================================
  Files          98       98              
  Lines        6924     6926       +2     
  Branches     1119     1120       +1     
==========================================
+ Hits         5969     5997      +28     
+ Misses        736      709      -27     
- Partials      219      220       +1     
Flag Coverage Δ
unittests 86.57% <33.33%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/pipelines/loading.py 89.59% <33.33%> (+3.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b88f1...1e74718. Read the comment docs.

@dreamerlin
Copy link
Collaborator

#279 is an issue about the dataset preparation scripts rather than the dataset pipeline. The #279 should not be linked by this.

@dreamerlin
Copy link
Collaborator

@innerlee innerlee merged commit 60c6e19 into open-mmlab:master Nov 27, 2020
@congee524 congee524 deleted the add_unittest_for_loading branch January 25, 2021 06:27
@OpenMMLab-Assistant003
Copy link

Hi @congee524!First of all, we want to express our gratitude for your significant PR in the MMAction2 project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @congee524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants