Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSN dataset. #37

Merged
merged 9 commits into from
Aug 31, 2020
Merged

Add SSN dataset. #37

merged 9 commits into from
Aug 31, 2020

Conversation

JackyTown
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #37 into master will increase coverage by 0.81%.
The diff coverage is 93.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   84.21%   85.02%   +0.81%     
==========================================
  Files          73       75       +2     
  Lines        4175     4588     +413     
  Branches      638      729      +91     
==========================================
+ Hits         3516     3901     +385     
- Misses        554      564      +10     
- Partials      105      123      +18     
Flag Coverage Δ
#unittests 85.02% <93.57%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/core/evaluation/accuracy.py 92.30% <88.33%> (-2.02%) ⬇️
mmaction/datasets/ssn_dataset.py 93.45% <93.45%> (ø)
mmaction/core/evaluation/__init__.py 100.00% <100.00%> (ø)
mmaction/datasets/__init__.py 100.00% <100.00%> (ø)
mmaction/datasets/pipelines/loading.py 94.11% <100.00%> (-0.02%) ⬇️
mmaction/localization/__init__.py 100.00% <100.00%> (ø)
mmaction/localization/ssn_utils.py 100.00% <100.00%> (ø)
mmaction/models/localizers/base.py 33.33% <0.00%> (-4.17%) ⬇️
mmaction/models/recognizers/base.py 60.81% <0.00%> (-2.01%) ⬇️
mmaction/datasets/base.py 67.24% <0.00%> (-1.10%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f183c1c...45cabff. Read the comment docs.

num_frames (int): Total frames of the video.
label (int): Classification of the proposal.
best_iou (int): The highest IOU with the groundtruth instance.
overlap_self (int): Percent of the proposal's own span contained
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does overlap_self has other candidate names? The self is very broad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, they use 'overlap_self' in mmaction1...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change it to something meaningful

@innerlee innerlee merged commit 25fbd3b into open-mmlab:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants