Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick add some explanation about the resampling in slowfast. #502

Merged
merged 3 commits into from
Jan 5, 2021

Conversation

SuX97
Copy link
Collaborator

@SuX97 SuX97 commented Dec 29, 2020

Fixes #496

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #502 (b604dba) into master (b540b6e) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   84.76%   84.71%   -0.05%     
==========================================
  Files         121      120       -1     
  Lines        8500     8407      -93     
  Branches     1394     1373      -21     
==========================================
- Hits         7205     7122      -83     
+ Misses        944      936       -8     
+ Partials      351      349       -2     
Flag Coverage Δ
unittests 84.70% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/backbones/resnet3d_slowfast.py 84.70% <ø> (ø)
mmaction/core/evaluation/accuracy.py 92.27% <0.00%> (-2.28%) ⬇️
mmaction/utils/__init__.py 100.00% <0.00%> (ø)
mmaction/models/losses/cross_entropy_loss.py 100.00% <0.00%> (ø)
mmaction/utils/precise_bn.py
mmaction/apis/train.py 15.00% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b540b6e...46182a9. Read the comment docs.

on input frames, corresponding to the :math:`\\tau` in the paper.
i.e., it processes only one out of ``resample_rate`` frames.
Default: 16.
on input frames. The actuall resample rate is calculated by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual

@innerlee innerlee merged commit 7dd249e into open-mmlab:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of SlowFast,4x16,R50 and SlowFast,8x8,R50 do not match that of the paper
2 participants