Support rawframe inference in demo and polish scripts and docs #59
Conversation
dreamerlin
commented
Jul 26, 2020
•
dreamerlin
commented
- Support rawframe inference in demo
- Raise Error when dataset type is not consist with the input type. (rawframe VS video)
- Polish demo scripts and docs
| model = init_recognizer(config_file, checkpoint_file, device=device, use_frames=True) | ||
|
|
||
| # test rawframe directory of a single video and show the result: | ||
| video = 'SOME_DIR_PATH/' |
There was a problem hiding this comment.
what's the structure of this dir, "SOME_DIR_PATH/video_name/img_xxxx.jpg" or "SOME_DIR_PATH/img_xxxx.jpg"?
There was a problem hiding this comment.
- When filename is "SOME_DIR_PATH/video_name/img_xxxx.jpg" and
data_prefixis None in config file.video = SOME_DIR_PATH/video_name. - When filename is "SOME_DIR_PATH/video_name/img_xxxx.jpg" and
data_prefixis "SOME_DIR_PATH" in config file.video = video_name. - When filename is "SOME_DIR_PATH/img_xxxx.jpg" and
data_prefixis None in config file.video = SOME_DIR_PATH.
There was a problem hiding this comment.
As a default, we set data_prefix=None in config file.
There was a problem hiding this comment.
is this info clear to reader?
There was a problem hiding this comment.
Add the description in a comment to make this info clear to readers.
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 84.95% 84.67% -0.28%
==========================================
Files 73 73
Lines 3874 3889 +15
Branches 627 632 +5
==========================================
+ Hits 3291 3293 +2
- Misses 482 490 +8
- Partials 101 106 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
docs/getting_started.md
Outdated
| @@ -129,6 +129,9 @@ device = torch.device(device) | |||
| model = init_recognizer(config_file, checkpoint_file, device=device) | |||
|
|
|||
| # test a single video and show the result: | |||
| # The real path for the video to get in this scripts will be `osp.path(data_prefix, video)`. | |||
There was a problem hiding this comment.
real path for the video is vague, because user is not sure what the video mean. does it mean the folder name of frames when using rawframe?
it will be good if you provide examples, rather than giving abstract description
innerlee
changed the title
