Support hmdb51 dataset preparation #60
Conversation
| @@ -0,0 +1,20 @@ | |||
| #! /usr/bin/bash env | |||
There was a problem hiding this comment.
this line looks suspicious. isn't it #!/usr/bin/env bash?
There was a problem hiding this comment.
Change it to #!/usr/bin/env bash. Same changes in other scripts are made in #62
|
|
||
| # sudo apt-get install unrar | ||
| unrar x test_train_splits.rar | ||
| rm test_train_splits.rar |
There was a problem hiding this comment.
it is very likely that user's pc does not have unrar installed. as a consequence, the newly downloaded data will be deleted without decompression. ref https://stackoverflow.com/questions/3474526/stop-on-first-error
There was a problem hiding this comment.
use set -e to make bash exit the script if any command fails
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 84.67% 84.67%
=======================================
Files 73 73
Lines 3889 3889
Branches 632 632
=======================================
Hits 3293 3293
Misses 490 490
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
No description provided.