Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit opencv-python version #689

Merged
merged 2 commits into from
Jan 2, 2022

Conversation

ckkelvinchan
Copy link
Member

Motivation

The latest opencv-python causes error in CI. This PR limits the version of it.

Modification

Modify requirements/runtime.txt

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #689 (bbe66c0) into master (4f814a8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   80.59%   80.61%   +0.01%     
==========================================
  Files         200      200              
  Lines       11419    11419              
  Branches     1831     1831              
==========================================
+ Hits         9203     9205       +2     
+ Misses       1932     1931       -1     
+ Partials      284      283       -1     
Flag Coverage Δ
unittests 80.58% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ls/components/stylegan2/generator_discriminator.py 86.14% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f814a8...bbe66c0. Read the comment docs.

@Yshuo-Li
Copy link
Collaborator

Lint failed

@ckkelvinchan
Copy link
Member Author

Lint failed

It passed now, but some CIs still failed. Could you help have a look?

@ckkelvinchan ckkelvinchan merged commit 07a0500 into open-mmlab:master Jan 2, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants