Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix example #1074

Merged
merged 7 commits into from
Jul 20, 2021
Merged

[Fix] Fix example #1074

merged 7 commits into from
Jul 20, 2021

Conversation

zhouzaida
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Original example didn't work and it is too complicated for new users. In this PR, I write a simpler example directly run by users.

Modification

  • Delete original example
  • Add simpler example

BC-breaking (Optional)

No BC-breaking

Use cases (Optional)

Run example

python example/train.py

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida zhouzaida changed the title [Fix] Fix example [WIP] Fix example Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1074 (4f08d37) into master (6c63621) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1074   +/-   ##
=======================================
  Coverage   67.99%   67.99%           
=======================================
  Files         159      159           
  Lines       10426    10426           
  Branches     1897     1897           
=======================================
  Hits         7089     7089           
  Misses       2968     2968           
  Partials      369      369           
Flag Coverage Δ
unittests 67.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c63621...4f08d37. Read the comment docs.

@hellock
Copy link
Member

hellock commented Jun 14, 2021

@mzr1996 may take a look.

examples/train.sh Outdated Show resolved Hide resolved
@zhouzaida
Copy link
Collaborator Author

@ZwwWayne

@zhouzaida zhouzaida changed the title [WIP] Fix example [Fix] Fix example Jun 20, 2021
examples/train.py Outdated Show resolved Hide resolved
examples/train.py Outdated Show resolved Hide resolved
examples/train.py Outdated Show resolved Hide resolved
examples/train.py Show resolved Hide resolved
examples/train.py Outdated Show resolved Hide resolved
@mzr1996
Copy link
Member

mzr1996 commented Jul 5, 2021

Should we add a test example? Users cannot evaluate training results from the example now.

@ZwwWayne
Copy link
Collaborator

Should we add a test example? Users cannot evaluate training results from the example now.

We can add a test example in a new PR.

@ZwwWayne ZwwWayne merged commit 74626ec into open-mmlab:master Jul 20, 2021
@zhouzaida zhouzaida deleted the fix-example branch November 4, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants