Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] use LooseVersion for version checking #1158

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

kennymckormick
Copy link
Member

Motivation

Origin version checking compares 2 strings, which leads to bugs like '0.8.0' > '0.10.0'

Modification

Use LooseVersion for Version Checking.

@kennymckormick
Copy link
Member Author

@zhouzaida

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1158 (5862fee) into master (76d9bf1) will increase coverage by 0.02%.
The diff coverage is 36.36%.

❗ Current head 5862fee differs from pull request most recent head 9b2f102. Consider uploading reports for the commit 9b2f102 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1158      +/-   ##
==========================================
+ Coverage   67.96%   67.98%   +0.02%     
==========================================
  Files         159      159              
  Lines       10416    10424       +8     
  Branches     1896     1896              
==========================================
+ Hits         7079     7087       +8     
  Misses       2969     2969              
  Partials      368      368              
Flag Coverage Δ
unittests 67.98% <36.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/parallel/distributed.py 22.44% <20.00%> (+1.61%) ⬆️
mmcv/runner/fp16_utils.py 58.38% <25.00%> (+0.26%) ⬆️
mmcv/ops/saconv.py 88.70% <33.33%> (+0.18%) ⬆️
mmcv/cnn/bricks/activation.py 88.00% <50.00%> (+0.50%) ⬆️
mmcv/parallel/distributed_deprecated.py 67.39% <50.00%> (+0.72%) ⬆️
mmcv/runner/dist_utils.py 50.49% <50.00%> (+0.49%) ⬆️
mmcv/runner/hooks/logger/tensorboard.py 36.36% <50.00%> (+1.98%) ⬆️
mmcv/runner/hooks/optimizer.py 17.29% <50.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d9bf1...9b2f102. Read the comment docs.

Copy link
Collaborator

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 1d5ee6e into open-mmlab:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants