Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on pip install mmcv-full torch1.9 cpu #1313

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Fix typo on pip install mmcv-full torch1.9 cpu #1313

merged 3 commits into from
Sep 7, 2021

Conversation

weiji14
Copy link
Contributor

@weiji14 weiji14 commented Sep 2, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix link on mmcv-full pip install instructions for torch1.9 cpu version

Modification

Edit link to point to https://download.openmmlab.com/mmcv/dist/cpu/torch1.9.0/index.html

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida mentioned this pull request Sep 2, 2021
16 tasks
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #1313 (fad827c) into master (d3b0572) will not change coverage.
The diff coverage is n/a.

❗ Current head fad827c differs from pull request most recent head 43ae3ba. Consider uploading reports for the commit 43ae3ba to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1313   +/-   ##
=======================================
  Coverage   68.81%   68.81%           
=======================================
  Files         161      161           
  Lines       10742    10742           
  Branches     1972     1972           
=======================================
  Hits         7392     7392           
  Misses       2962     2962           
  Partials      388      388           
Flag Coverage Δ
unittests 68.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b0572...43ae3ba. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 9016fef into open-mmlab:master Sep 7, 2021
@weiji14 weiji14 deleted the cpu-install-typo branch September 7, 2021 10:10
@OpenMMLab-Assistant003
Copy link

Hi @weiji14!First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @weiji14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants