Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the docker image provided by PyTorch #1376

Merged
merged 4 commits into from
Oct 3, 2021

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Sep 26, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Refer to open-mmlab/mmdetection#5862

Switch to the docker image provided by PyTorch and remove some workflows that verify mmcv whether works well in the CPU version of PyTorch 1.3.0 and 1.4.0.

Modification

modify .github/workflow/build.yml

BC-breaking (Optional)

No

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida changed the title switch to the docker image provided by PyTorch Switch to the docker image provided by PyTorch Sep 27, 2021
fix sudo error

fix ci

fix ci

fix ci

fix ci

fix ci

fix ci

fix ci

fix ci

fix ci

fix ci

fix ci

fix ci

fix ci
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Oct 2, 2021

may leave a comment to indicate why python -m is necessary

@zhouzaida
Copy link
Collaborator Author

may leave a comment to indicate why python -m is necessary

done

@ZwwWayne ZwwWayne merged commit c934605 into open-mmlab:master Oct 3, 2021
@zhouzaida zhouzaida deleted the switch-docker-image branch November 4, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants