Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify adaptation of bbox_overlaps op for ascend device #2697

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Modify adaptation of bbox_overlaps op for ascend device #2697

merged 2 commits into from
Mar 24, 2023

Conversation

dflhw
Copy link
Contributor

@dflhw dflhw commented Mar 24, 2023 •
edited

  1. At present, compared with the bbox_overlaps operator, the iou operator on ascend device has precision error in the fp16 case and does not meet the acceptance standard, so go to the fp32 branch temporarily to avoid the problem.
  2. Add support for offset at 0.
  3. This change is independent of torch_npu.

@zhouzaida zhouzaida added the NPU Ascend label Mar 24, 2023
ckirchhoff2021
ckirchhoff2021 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more notes to the modifications next time.

@dflhw
Copy link
Contributor Author

dflhw commented Mar 24, 2023

Add more notes to the modifications next time.

ok.

@zhouzaida zhouzaida merged commit 4c4ba6c into open-mmlab:master Mar 24, 2023
CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
@dflhw @CokeDong
[Fix] Force bbox_overlaps calculation with FP32 for ascend device (op…
a3dba8e 
…en-mmlab#2697)

* modify bbox_overlaps op adapter

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckirchhoff2021 ckirchhoff2021 ckirchhoff2021 approved these changes

Assignees

@ice-tong ice-tong

Labels
NPU Ascend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dflhw @ckirchhoff2021 @ice-tong @zhouzaida