Modify adaptation of bbox_overlaps op for ascend device #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dflhw
commented
Mar 24, 2023
•
dflhw
commented
- At present, compared with the bbox_overlaps operator, the iou operator on ascend device has precision error in the fp16 case and does not meet the acceptance standard, so go to the fp32 branch temporarily to avoid the problem.
- Add support for offset at 0.
- This change is independent of torch_npu.
ckirchhoff2021
approved these changes
Mar 24, 2023
ok. |
CokeDong
pushed a commit
to CokeDong/mmcv
that referenced
this pull request
Apr 24, 2023
…en-mmlab#2697) * modify bbox_overlaps op adapter * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.