Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slice support and unit test #9

Merged
merged 4 commits into from
Sep 27, 2018
Merged

add slice support and unit test #9

merged 4 commits into from
Sep 27, 2018

Conversation

ycxioooong
Copy link
Contributor

@ycxioooong ycxioooong commented Sep 26, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #9 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   53.46%   53.61%   +0.14%     
==========================================
  Files          53       53              
  Lines        1906     1910       +4     
==========================================
+ Hits         1019     1024       +5     
+ Misses        887      886       -1
Impacted Files Coverage Δ
mmcv/video/io.py 96.29% <100%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c211ab1...6249f82. Read the comment docs.

imgs = v[-105:-103]
assert int(round(imgs[0].mean())) == 94
assert int(round(imgs[1].mean())) == 205

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more tests here. e.g., v[:3], v[1:5], v[160:], v[-5:]

@hellock hellock mentioned this pull request Sep 26, 2018
2 tasks
@hellock hellock merged commit 93620a2 into open-mmlab:master Sep 27, 2018
haofengac pushed a commit to haofengac/mmcv that referenced this pull request Nov 30, 2019
add slice support and unit test
pablodecm pushed a commit to pablodecm/mmcv that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants