-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] NMS update #957
[Feature] NMS update #957
Conversation
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
==========================================
+ Coverage 65.20% 65.70% +0.49%
==========================================
Files 156 157 +1
Lines 10034 10086 +52
Branches 1816 1829 +13
==========================================
+ Hits 6543 6627 +84
+ Misses 3154 3113 -41
- Partials 337 346 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@SemyonBevzuk , Could you fix CI error? |
@ZwwWayne See if you have any comments on this PR. |
@SemyonBevzuk hi,could you kindly fix the CI error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kindly ping @ZwwWayne |
Added support for "score_threshold" and "max_num" for NMS operation when exporting to ONNX.
These parameters are supported in ONNX: link.
These changes significantly speed up the export time:
In addition, performance is improved in ONNX Runtime.
This can be seen in the example of the RetinaNet model.
Performance measured using standard ONNX Runtime tools on 10 random inputs.
The table shows the average execution time of the NMS operation and the total inference time of the model: