Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix onnx2ncnn.cpp bugs. #1518

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

hanrui1sensetime
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix some of onnx2ncnn.cpp bugs. Especially for RTMPose model deployment later.

Modification

-[x] Fix Gemm for opset > 9, which is optional for the third input, while original onnx2ncnn needs the third input strictly.
-[x] Sync the Reduction op from the newest onnx2ncnn in ncnn

Other ops sync from the newest onnx2ncnn in ncnn
will be fixed later in another PR. This PR is mainly for RTMPose model.

BC-breaking (Optional)

None.

Use cases (Optional)

None.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could add ut for this case

@lvhan028
Copy link
Collaborator

could add ut for this case

It's onnx2ncnn.cpp, coming from ncnn repo. I think we don't need to add unit tests for it.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 7f2e8f7 into open-mmlab:dev-1.x Dec 29, 2022
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
* fix onnx2ncnn

* remove unused debugging info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants