Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix some of onnx2ncnn.cpp bugs. Especially for
RTMPose
model deployment later.Modification
-[x] Fix
Gemm
for opset > 9, which is optional for the third input, while original onnx2ncnn needs the third input strictly.-[x] Sync the
Reduction
op from the newest onnx2ncnn in ncnnOther ops sync from the newest onnx2ncnn in ncnn
will be fixed later in another PR. This PR is mainly for
RTMPose
model.BC-breaking (Optional)
None.
Use cases (Optional)
None.
Checklist