Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix reduction fp16 exceed #1819

Merged

Conversation

hanrui1sensetime
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

RTMPose FP16 model will be nan on Android platform using ncnn. So force set ncnn Reduction op for FP32.

Modification

Add 31=15 to Reduction layer params automatically when executing onnx2ncnn.

BC-breaking (Optional)

None.

Use cases (Optional)

None.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 added the Bug:P1 label Mar 1, 2023
@lvhan028 lvhan028 merged commit 84a289f into open-mmlab:dev-1.x Mar 1, 2023
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
@nihui
Copy link

nihui commented Mar 2, 2023

这个31参数feature是怎么被发现的

@lvhan028
Copy link
Collaborator

lvhan028 commented Mar 3, 2023

这个31参数feature是怎么被发现的

正如 @hanrui1sensetime 在motivation中写的那样:
RTMPose FP16 model will be nan on Android platform using ncnn

FYI, RTMPose 模型还没有正式release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants