Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobilenet V3 to ONNX support #2256

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Conversation

Macok
Copy link
Contributor

@Macok Macok commented Jul 6, 2023

Motivation

Support conversion of mmpretrain's Mobilenet V3 classification models to ONNX.

Modification

Fixes error that was arising during conversion to ONNX: #2245

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023

CLA assistant check
All committers have signed the CLA.

@RunningLeon
Copy link
Collaborator

@Macok hi, thanks for your PR. Could you add mobilenetv3 in the regression test config and run the test to see whether some backends are supported.

  1. pull docker image openmmlab/mmdeploy:ubuntu20.04-cuda11.3-mmdeploy1.2.0 and create container by refering to https://mmdeploy.readthedocs.io/en/latest/01-how-to-build/build_from_docker.html
  2. Add config for mobilenetv3 in https://github.com/open-mmlab/mmdeploy/blob/main/tests/regression/mmpretrain.yml#L241
  3. run python3 tools/regressiont_test.py --codebase mmpretrain --models MobileNetV3 --work-dir ./workdir
  4. check regression result in ./workdir and update model support list in https://github.com/open-mmlab/mmdeploy/blob/main/docs/zh_cn/04-supported-codebases/mmpretrain.md and https://github.com/open-mmlab/mmdeploy/blob/main/docs/en/04-supported-codebases/mmpretrain.md

@OpenMMLab-Assistant-004

Hi @Macok,

We'd like to express our appreciation for your valuable contributions to the mmdeploy. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
...eploy/codebase/mmpretrain/deploy/classification.py 0.00%

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not update its performance on the ONNXRuntime backend?

@RunningLeon RunningLeon merged commit 58db0ad into open-mmlab:main Sep 5, 2023
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants