Improve ncnn patch embed #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimoire
reviewed
Jun 14, 2022
grimoire
reviewed
Jun 14, 2022
|
How to generate the graph in this PR? Looks cool. |
Just markdown. “ ```mermaid ” flowchart TD; “ conv-->reshape; ” ``` |
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
- Coverage 57.42% 57.38% -0.05%
==========================================
Files 258 259 +1
Lines 8561 8574 +13
Branches 1279 1281 +2
==========================================
+ Hits 4916 4920 +4
- Misses 3292 3301 +9
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lvhan028
approved these changes
Jun 14, 2022
grimoire
approved these changes
Jun 15, 2022
grimoire
pushed a commit
to grimoire/mmdeploy
that referenced
this pull request
Jun 25, 2022
* improvement(PatchEmbed): use reshape instead of flatten * improvement(init_plugins.py): get onnx2ncnn path * fix(CI): build error * fix(CI): revert get onnx2ncnn path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Modification
before:
flowchart TD; conv-->shape; shape-->slice; slice-->concat; concat-->reshape; conv-->reshape;after:
flowchart TD; conv-->reshape;if
get_onnx2ncnn_pathfailed, give more tipsfix-typo
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist