Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_negative_crop in RandomCrop #3153

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

Johnson-Wang
Copy link
Collaborator

@Johnson-Wang Johnson-Wang commented Jun 30, 2020

  1. Add allow_negative_crop in RandomCrop
  2. Resolve a TODO: check whether we can keep the image regardless of the crop.
  3. Find out the reason of a sudden boost of nas-fpn performance using the RandomCrop in Fixed bugs in transform.py #2810. In Fixed bugs in transform.py #2810, the allow_negative_crop was implicitly set to True when there is gt_bboxes_ignore flag and gt_bboxes_ignore is an empty tensor.
    I will keep gt_bboxes_ignore=False in this version and provide the performance with gt_bboxes_ignore=True in the nas-fpn README.

Conclusion after re-running the experiments

The performance is very close for coco dataset with gt_bbox_ignore=True or gt_bbox_ignore=False. Both of these are higher than that reported in the model zoo

before #2810 #2810 gt_bbox_ignore=True gt_bbox_ignore=False
retinanet_fpn_crop640 37.4 37.9 37.8 37.9
retinanet_nas_fpn_crop640 40.2 40.5 40.6 40.7

@Johnson-Wang Johnson-Wang changed the title WIP: add allow_negative_crop in RandomCrop Add allow_negative_crop in RandomCrop Jul 7, 2020
@hellock hellock merged commit cdfc6a1 into open-mmlab:master Jul 8, 2020
mike112223 pushed a commit to mike112223/mmdetection that referenced this pull request Aug 25, 2020
* add allow_negative_crop in RandomCrop

* Revise docstring

* change according to comments
liuhuiCNN pushed a commit to liuhuiCNN/mmdetection that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants