-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of TridentNet #3313
Conversation
Hi @Chrisfsj2051 , I'm very interested in TridentNet as well. Is it runable in your repository? |
Hi @TWDH , Sorry for the Late Reply. Sure, it is already runnable. |
Codecov Report
@@ Coverage Diff @@
## master #3313 +/- ##
==========================================
- Coverage 62.66% 62.59% -0.08%
==========================================
Files 232 235 +3
Lines 17597 17818 +221
Branches 2942 2983 +41
==========================================
+ Hits 11028 11153 +125
- Misses 6031 6123 +92
- Partials 538 542 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @Johnson-Wang and @hellock , I tried to train TridentNet (as well as FRCNN-C4) with both Iteration-Based and Epoch-Based to see the difference, here's the result:
As shown in this table, with iteration-based 1x schedule (~12.3 epoch), this implementation yield 37.9mAP (0.1 lower than detr2). However, under 3x schedule, TridentNet is ~0.4 lower than detr2 and Frcnn-C4 is ~0.3 lower than detr2. I'm wondering if it is qualified to be viewed or merged? |
@Chrisfsj2051 Hi, Thanks for reply. I have a question: What's your baseline's mAP? As far as I know, the official FasterRCNN in mmedetection is already 37.8% at https://github.com/open-mmlab/mmdetection/tree/master/configs/faster_rcnn. detectron2 improves the performance from 35.7 to 38. Does you code have the same improvement? Thanks, just curious. |
Hi @TWDH , the 35.7 mAP FRCNN in detectron2 is FRCNN-C4. The 37.8 mAP FRCNN in mmdet that you mentioned above, however, is FRCNN-FPN, which has 37.9 mAP in detectron2 implementation (R50-FPN). TridentNet is based on FRCNN C4. |
Task linked: CU-4btyv9 TridentNet PR review & Merge |
It shows "You do not have access to this task code: ACCESS_083" with account "fangshijie@sensetime.com" |
@Chrisfsj2051 I'm really interested in your work, especially ResNet101-deformable. How can i use your work? I'm a github novice. thanks |
Using all of 3 branches for inference, we can improve the mAP of mstrain-3x setting model from 40.3 to 40.6. |
Implementation of TridentNet.
Please note that this implementation refers to the implementation in detectron2, which is slightly different from the origin paper. In paper, the author use r50 to conduct abaltion study, but report final results based on r101. While in detectron2, all experiments are conducted with r50. Besides, the author use all 3 branches to yield best performance, but detectron2 only uses the middle branch (index=1, dilation=2).
This implementation is still work in progress, for slightly lower accuracy comparing to detectron2. The unit test will be added after accuracy meets expect.
Update 7.20: The faster-rcnn C4 baseline with 3x schedule failed to reach the accuracy in detectron2.