Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed BC of stem_channels #3333

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Fixed BC of stem_channels #3333

merged 3 commits into from
Jul 17, 2020

Conversation

xvjiarui
Copy link
Collaborator

No description provided.

Johnson-Wang
Johnson-Wang reviewed Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@Johnson-Wang Johnson-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me in regards to the code. It's better to check configs that need to set stem_channels explicitly. BTW, how come I didn't find any configs with stem_channels arguments?

mmdet/models/backbones/resnet.py Outdated Show resolved Hide resolved
@xvjiarui
Copy link
Collaborator Author

It seems good to me in regards to the code. It's better to check configs that need to set stem_channels explicitly. BTW, how come I didn't find any configs with stem_channels arguments?

The default value works for all configs. I just did a global search and didn't find any config need modification.

@hellock hellock merged commit adc65ff into open-mmlab:master Jul 17, 2020
mike112223 pushed a commit to mike112223/mmdetection that referenced this pull request Aug 25, 2020
@xvjiarui
Fixed BC of stem_channels (open-mmlab#3333)
84addf6 
* Fixed BC of stem_channels

* fixed init

* typo
FANGAreNotGnu pushed a commit to FANGAreNotGnu/mmdetection that referenced this pull request Oct 23, 2023
@Innixma
Add community section to website front page (open-mmlab#3333)
1c5e250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellock hellock hellock approved these changes

@Johnson-Wang Johnson-Wang Johnson-Wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xvjiarui @Johnson-Wang @hellock