Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imresize backend #3392

Merged
merged 7 commits into from
Aug 4, 2020
Merged

Imresize backend #3392

merged 7 commits into from
Aug 4, 2020

Conversation

Johnson-Wang
Copy link
Collaborator

Enable flexible backend for imresize

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #3392 into master will decrease coverage by 0.09%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3392      +/-   ##
==========================================
- Coverage   57.97%   57.88%   -0.10%     
==========================================
  Files         202      202              
  Lines       13491    13493       +2     
  Branches     2282     2282              
==========================================
- Hits         7822     7811      -11     
- Misses       5310     5322      +12     
- Partials      359      360       +1     
Flag Coverage Δ
#unittests 57.88% <40.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/losses/iou_loss.py 29.94% <0.00%> (ø)
mmdet/datasets/pipelines/transforms.py 73.09% <66.66%> (-0.08%) ⬇️
mmdet/models/roi_heads/mask_scoring_roi_head.py 81.57% <0.00%> (-18.43%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 92.30% <0.00%> (-5.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b05c17e...c62ec6d. Read the comment docs.

@hellock
Copy link
Member

hellock commented Jul 24, 2020

There are also other transforms like SegRescale which needs to be updated.

@hellock
Copy link
Member

hellock commented Jul 26, 2020

We need to update the minimum version of mmcv in requirements and readme.

@Johnson-Wang
Copy link
Collaborator Author

Since there is currently no version requirement for mmcv in requirements and readme, I can wait for the next version bump of mmdetection to merge this pr.

@hellock hellock merged commit c4c9d9f into open-mmlab:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants