Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to runner meta #3534

Merged
merged 6 commits into from
Aug 28, 2020
Merged

Conversation

Johnson-Wang
Copy link
Collaborator

@Johnson-Wang Johnson-Wang commented Aug 11, 2020

'config' is added to runner meta at first.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #3534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3534   +/-   ##
=======================================
  Coverage   60.94%   60.94%           
=======================================
  Files         205      205           
  Lines       13827    13827           
  Branches     2344     2344           
=======================================
  Hits         8427     8427           
  Misses       4971     4971           
  Partials      429      429           
Flag Coverage Δ
#unittests 60.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b3b66...f8307a7. Read the comment docs.

tools/train.py Outdated Show resolved Hide resolved
@Johnson-Wang Johnson-Wang changed the title Add config and config filename to runner meta Add config to runner meta Aug 28, 2020
@@ -156,7 +156,6 @@ def main():
# checkpoints as meta data
cfg.checkpoint_config.meta = dict(
mmdet_version=__version__ + get_git_hash()[:7],
config=cfg.pretty_text,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta['config'] is added in line 133.

@hellock hellock merged commit f93c00f into open-mmlab:master Aug 28, 2020
liuhuiCNN pushed a commit to liuhuiCNN/mmdetection that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants