Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rescale boxes when their number is 0 #3575

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

mprzewie
Copy link
Contributor

Before this fix, an attempt to rescale an empty tensor of bounding boxes (i.e. of shape (0,4) ) results in the following error:

RuntimeError: Cannot reshape tensor of 0 elements into shape [0, -1, -4] because the unspecified dimension size -1 can be any value and is ambiguous.

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2020

CLA assistant check)
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #3575 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3575      +/-   ##
==========================================
- Coverage   59.04%   59.00%   -0.04%     
==========================================
  Files         205      205              
  Lines       13731    13731              
  Branches     2315     2315              
==========================================
- Hits         8107     8102       -5     
  Misses       5248     5248              
- Partials      376      381       +5     
Flag Coverage Δ
#unittests 59.00% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/roi_heads/bbox_heads/bbox_head.py 85.06% <0.00%> (ø)
mmdet/models/dense_heads/rpn_test_mixin.py 77.41% <0.00%> (-6.46%) ⬇️
mmdet/models/roi_heads/test_mixins.py 50.53% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acf6be...60b0bfb. Read the comment docs.

@hellock
Copy link
Member

hellock commented Aug 18, 2020

Thanks for the fix!

@hellock hellock merged commit c31df74 into open-mmlab:master Aug 18, 2020
@OpenMMLab-Assistant-007
Copy link

Hi!
@mprzewie
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

FANGAreNotGnu pushed a commit to FANGAreNotGnu/mmdetection that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants