fix bug when RepPoints run in a specific gpu instead of cuda:0 #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3836 +/- ##
==========================================
+ Coverage 60.93% 61.55% +0.61%
==========================================
Files 217 216 -1
Lines 15374 15517 +143
Branches 2628 2634 +6
==========================================
+ Hits 9368 9551 +183
+ Misses 5537 5489 -48
- Partials 469 477 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xvjiarui
reviewed
Sep 25, 2020
| @@ -534,6 +534,7 @@ def loss_single(self, cls_score, pts_pred_init, pts_pred_refine, labels, | |||
| label_weights = label_weights.reshape(-1) | |||
| cls_score = cls_score.permute(0, 2, 3, | |||
| 1).reshape(-1, self.cls_out_channels) | |||
| cls_score = cls_score.contiguous() | |||
There was a problem hiding this comment.
reshape should have done contiguous() implicitly.
Will there be bugs if this line is removed?
There was a problem hiding this comment.
reshapeshould have donecontiguous()implicitly.
Will there be bugs if this line is removed?
yes , focal_loss will throw RuntimeError
mmcv/ops/focal_loss.py", line 55, in forward
input, target, weight, output, gamma=ctx.gamma, alpha=ctx.alpha)
RuntimeError: input must be contiguous
xvjiarui
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3828