Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support unclip border bbox regression #4076

Merged
merged 11 commits into from
Nov 19, 2020
Merged

Conversation

OceanPang
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #4076 (f3131bc) into master (eb7bfbc) will decrease coverage by 0.37%.
The diff coverage is 43.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4076      +/-   ##
==========================================
- Coverage   62.25%   61.87%   -0.38%     
==========================================
  Files         221      225       +4     
  Lines       16321    16670     +349     
  Branches     2762     2823      +61     
==========================================
+ Hits        10160    10314     +154     
- Misses       5666     5851     +185     
- Partials      495      505      +10     
Flag Coverage Δ
unittests 61.82% <43.06%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/inference.py 20.48% <0.00%> (-1.04%) ⬇️
mmdet/core/anchor/anchor_generator.py 78.98% <ø> (ø)
...mdet/core/bbox/iou_calculators/iou2d_calculator.py 96.77% <ø> (ø)
mmdet/core/utils/misc.py 100.00% <ø> (+33.33%) ⬆️
mmdet/models/dense_heads/anchor_head.py 85.84% <ø> (ø)
mmdet/models/dense_heads/atss_head.py 27.94% <0.00%> (-0.26%) ⬇️
mmdet/models/dense_heads/gfl_head.py 27.35% <ø> (-0.04%) ⬇️
mmdet/models/dense_heads/rpn_head.py 84.93% <0.00%> (ø)
mmdet/models/dense_heads/yolo_head.py 34.04% <0.00%> (-0.19%) ⬇️
mmdet/models/losses/focal_loss.py 43.90% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7bfbc...aaf3352. Read the comment docs.

.gitignore Show resolved Hide resolved
@@ -17,11 +17,14 @@ class TBLRBBoxCoder(BaseBBoxCoder):
divided with when coding the coordinates. If it is a list, it should
have length of 4 indicating normalization factor in tblr dims.
Otherwise it is a unified float factor for all dims. Default: 4.0
clip_border (bool): Whether clip the objects outside the border of
the image.
Copy link
Collaborator

@ZwwWayne ZwwWayne Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults to True.

@@ -136,6 +141,8 @@ def tblr2bboxes(priors,
normalized by the side length (wh) of prior bboxes.
max_shape (tuple, optional): Shape of the image. Decoded bboxes
exceeding which will be clamped.
clip_border (bool): Whether clip the objects outside the border of
the image.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults to True.

@ZwwWayne ZwwWayne merged commit caa4a4e into open-mmlab:master Nov 19, 2020
@gritYCDA
Copy link

gritYCDA commented Apr 3, 2022

YOLOBBoxCoder doesn't have clip_border, may I know why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants