Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytorch 1.7 imcompatibility issues #4103

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

hellock
Copy link
Member

@hellock hellock commented Nov 13, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #4103 (6ed04aa) into master (490b6ee) will decrease coverage by 0.02%.
The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4103      +/-   ##
==========================================
- Coverage   61.91%   61.89%   -0.03%     
==========================================
  Files         224      225       +1     
  Lines       16634    16645      +11     
  Branches     2811     2815       +4     
==========================================
+ Hits        10299    10302       +3     
- Misses       5836     5845       +9     
+ Partials      499      498       -1     
Flag Coverage Δ
unittests 61.85% <65.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/inference.py 20.48% <0.00%> (-1.04%) ⬇️
mmdet/core/anchor/anchor_generator.py 78.98% <ø> (ø)
...mdet/core/bbox/iou_calculators/iou2d_calculator.py 96.77% <ø> (ø)
mmdet/models/dense_heads/atss_head.py 27.94% <ø> (-0.02%) ⬇️
mmdet/models/dense_heads/gfl_head.py 27.35% <ø> (-0.04%) ⬇️
mmdet/models/dense_heads/vfnet_head.py 31.48% <ø> (+0.07%) ⬆️
mmdet/models/losses/focal_loss.py 43.90% <0.00%> (ø)
mmdet/core/utils/dist_utils.py 25.64% <16.66%> (-1.64%) ⬇️
mmdet/models/necks/channel_mapper.py 84.21% <84.21%> (ø)
mmdet/core/utils/__init__.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490b6ee...64af129. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 01f1d42 into open-mmlab:master Nov 17, 2020
@dreamflasher
Copy link

@ZwwWayne Thanks a lot for this! According to the readme mmdetection does not support 1.7 yet: https://github.com/open-mmlab/mmdetection/blob/master/README.md – is the readme outdated?

@hellock hellock deleted the fix-pytorch1.7 branch April 10, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants