Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed example hook name it was specified wrongly in useful_hook doc. #8118

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

p-mishra1
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Updating the useful_hook doc example.

Modification

In the example of how to create a custom hook the hook name should be added to config instead a different name is given in the steps.

BC-breaking (Optional)

Use cases (Optional)

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne ZwwWayne requested a review from chhluo June 5, 2022 09:17
@ZwwWayne ZwwWayne changed the base branch from master to dev June 5, 2022 09:17
@ZwwWayne ZwwWayne merged commit c1ab941 into open-mmlab:dev Jun 7, 2022
ZwwWayne added a commit to ZwwWayne/mmdetection that referenced this pull request Jul 28, 2022
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
@OpenMMLab-Assistant-004
Copy link

Hi @p-mishra1 !First of all, we want to express our gratitude for your significant PR in the mmdetection project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants