Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] set new hw on macos #8434

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

grimoire
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

#4926

Modification

Set height and width on macOS.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #8434 (e487cdd) into master (56e42e7) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #8434      +/-   ##
==========================================
- Coverage   64.17%   64.15%   -0.03%     
==========================================
  Files         361      361              
  Lines       29525    29528       +3     
  Branches     5019     5020       +1     
==========================================
- Hits        18948    18944       -4     
- Misses       9575     9577       +2     
- Partials     1002     1007       +5     
Flag Coverage Δ
unittests 64.13% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/visualization/image.py 63.50% <33.33%> (-0.46%) ⬇️
mmdet/core/bbox/samplers/random_sampler.py 75.00% <0.00%> (-5.56%) ⬇️
mmdet/utils/setup_env.py 88.00% <0.00%> (-4.00%) ⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py 72.36% <0.00%> (-1.32%) ⬇️
mmdet/datasets/builder.py 52.08% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e42e7...e487cdd. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 29e1650 into open-mmlab:master Jul 27, 2022
triple-Mu pushed a commit to triple-Mu/mmdetection that referenced this pull request Nov 5, 2022
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants