Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pre commit hooks in dev-3.x #8963

Merged
merged 5 commits into from
Oct 8, 2022
Merged

Upgrade pre commit hooks in dev-3.x #8963

merged 5 commits into from
Oct 8, 2022

Conversation

wanghonglie
Copy link

@wanghonglie wanghonglie commented Oct 8, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The motivation to upgrade some versions of pre-commit hooks to latest is that importlib-metadata v5.0.0 which removed deprecated endpoint breaks the flake8. More details at https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean/73932581#73932581.

Modification

Upgrade some versions of pre-commit hooks in dev-3.x.

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@MambaWong MambaWong mentioned this pull request Oct 8, 2022
@ZwwWayne ZwwWayne merged commit 358ce65 into open-mmlab:dev-3.x Oct 8, 2022
@wanghonglie wanghonglie deleted the upgrade-pre-commit-hooks branch October 8, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants