Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] add opencv to docs dependency & setup.py to resolve API docs error #113

Merged
merged 8 commits into from
Mar 15, 2023

Conversation

C1rN09
Copy link
Collaborator

@C1rN09 C1rN09 commented Mar 15, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@C1rN09 C1rN09 requested a review from zhouzaida as a code owner March 15, 2023 05:35
@C1rN09 C1rN09 changed the title [Fix] add opencv to setup.py as a runtime dependency to fix api docs error [Fix] add opencv to docs dependency & fix utils to resolve api docs error Mar 15, 2023
@C1rN09 C1rN09 changed the title [Fix] add opencv to docs dependency & fix utils to resolve api docs error [Fix] add opencv to docs dependency & setup.py to resolve API docs error Mar 15, 2023
requirements/docs.txt Outdated Show resolved Hide resolved
C1rN09 and others added 2 commits March 15, 2023 15:05
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida merged commit 9ce87f0 into open-mmlab:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants