Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix CI failed caused by OneFlow installation and new version of NumPy #73

Merged
merged 7 commits into from
Jan 5, 2023
Merged

[Fix] Fix CI failed caused by OneFlow installation and new version of NumPy #73

merged 7 commits into from
Jan 5, 2023

Conversation

ice-tong
Copy link
Collaborator

@ice-tong ice-tong commented Jan 3, 2023 •
edited
Loading

Motivation

The CI failed with the following 2 reasons:

  1. OneFlow OSS download could be failed.
  2. The new version release of NumPy (1.24.1)

Modification

According to the NumPy deprecations: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
image

  • Using bool instead of np.bool
  • Using float instead of np.float
  • Using np.int32 instead of np.int (Consistent with context)
  • Skip OneFlow installation if failed

@zhouzaida zhouzaida merged commit c208533 into open-mmlab:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ice-tong @zhouzaida