Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support overall dastaloader settings #117

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

MeowZheng
Copy link
Collaborator

@MeowZheng MeowZheng commented Apr 13, 2022

Motivation

open-mmlab/mmpretrain#752

Modification

  1. Add overall dataloader cfg in api/train.py
  2. Add overall dataloader cfg in tools/test.py

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #117 (ee7a689) into master (31568b1) will decrease coverage by 0.77%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   69.56%   68.78%   -0.78%     
==========================================
  Files          92       92              
  Lines        5092     5135      +43     
  Branches      721      727       +6     
==========================================
- Hits         3542     3532      -10     
- Misses       1438     1489      +51     
- Partials      112      114       +2     
Flag Coverage Δ
unittests 68.78% <0.00%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmflow/apis/train.py 20.61% <0.00%> (-0.66%) ⬇️
mmflow/datasets/pipelines/transforms.py 77.50% <0.00%> (-3.67%) ⬇️
mmflow/datasets/utils/flow_io.py 32.77% <0.00%> (-2.30%) ⬇️
mmflow/datasets/utils/__init__.py 100.00% <0.00%> (ø)
mmflow/datasets/dataset_wrappers.py 43.75% <0.00%> (ø)
mmflow/datasets/pipelines/loading.py 71.09% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31568b1...ee7a689. Read the comment docs.

@MeowZheng MeowZheng merged commit 465ae5d into open-mmlab:master Apr 13, 2022
@MeowZheng MeowZheng deleted the dataloader-cfg branch April 13, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant