[Fix] Fix potential circular import in core, data and utils, disconnect unnecessary pytorch3d dependency #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 85.24% 85.05% -0.20%
==========================================
Files 170 173 +3
Lines 14832 14826 -6
==========================================
- Hits 12644 12610 -34
- Misses 2188 2216 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Import time compare:
|
|
Import failure compare if pytorch3d is not installed S: success, F: failure, W: success with a warning.
|
LazyBusyYang
changed the title
|
Is this file meant to be included in the main branch? |
ttxskk
approved these changes
Jun 9, 2022
ttxskk
reviewed
Jun 9, 2022
docs/visualize_smpl.md
Outdated
| @@ -29,7 +29,7 @@ | |||
| If you want to visualize a T-pose smpl or your poses do not have global_orient, you can do: | |||
| ```python | |||
| import torch | |||
| from mmhuman3d.core.visualization import visualize_T_pose | |||
| from mmhuman3d.core.visualization. import visualize_T_pose | |||
There was a problem hiding this comment.
Here should be from mmhuman3d.core.visualization.visualize_smpl import visualize_T_pose ?
There was a problem hiding this comment.
Fixed in 2dd48b7.
ttxskk
approved these changes
Jun 10, 2022
ttxskk
pushed a commit
to ttxskk/mmhuman3d
that referenced
this pull request
Jun 30, 2022
…ct unnecessary pytorch3d dependency (open-mmlab#190) - Move mmhuman3d.core.visualization.renderer to mmhuman3d.core.renderer - Split mmhuman3d.core.renderer.torch3d_renderer.builder into several seperated builders. - Make __init__.py in mmhuman3d.core.renderer, mmhuman3d.data, mmhuman3d.utils empty. - Allow pytorch3d import failure in mmhuman3d.utils.transforms, because the transforms.py is widely imported by many modules that do not need pytorch3d at all (transforms.py is introduced by demo_utils.py). - Fix failed tests caused by the changes above. - Accept mmcv 1.5.2. Co-authored-by: gaoyang3 <gaoyang3@sensetime.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmhuman3d.core.visualization.renderertommhuman3d.core.renderermmhuman3d.core.renderer.torch3d_renderer.builderinto several seperated builders.__init__.pyin mmhuman3d.core.renderer, mmhuman3d.data, mmhuman3d.utils empty.Below are some cases indicates what is different in this PR.
case 1. When we are trying to import
visualize_kp2dbefore this PR:
All the torch3d renderers, lights and shaders, vedo_renderer are imported because of
__init__.py.If pytorch3d has not been installed(e.g. OS or hardware not supported), program exits because of the module we never use.
after this PR:
Only the modules related to visualize_kp2d are imported.
If pytorch3d has not been installed, the program casts a warning message of import error and call stack, goes on, allows you to visualize kp2d.
case 2. When we are trying to import
ParametricMeshesbefore this PR:
All the torch3d renderers, lights and shaders, matplotlib_renderer, vedo_renderer are imported because of
__init__.py.after this PR:
Only the
ParametricMeshesis imported, with a price of longer import sentence.case 3. When we are trying to import
build_rendererbefore this PR:
from mmhuman3d.core.visualization.renderer import build_renderer.after this PR:
from mmhuman3d.core.renderer.torch3d_renderer.builder import build_renderer. A little bit longer.case 4. When we are trying to import
MeshRenderer, PointCloudRendererbefore this PR:
from mmhuman3d.core.visualization.renderer import MeshRenderer, PointCloudRenderer.after this PR:
from mmhuman3d.core.renderer.torch3d_renderer.builder import MeshRenderer, PointCloudRenderer. Classes in same registry can be accessed in builder, one line import.case 5. When we are trying to import
HumanDatabefore this PR:
If pytorch3d has not been installed, program exits because that it is imported by SMCReader.
after this PR:
If pytorch3d has not been installed, nothing happens. You can use the module as you wish.