Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support file_client_args in LoadImageFromFile #1076

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Dec 9, 2021

Motivation

Support file_client_args in LoadImageFromFile. Similar to this in mmdet:

https://github.com/open-mmlab/mmdetection/blame/0b94be76b89fcbbfd83ef2a1a67818b5948280d1/mmdet/datasets/pipelines/loading.py#L12

Modification

LoadImageFromFile in loading.py

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@jin-s13 jin-s13 requested a review from ly015 December 9, 2021 07:47
@jin-s13 jin-s13 changed the title support file_client_args in LoadImageFromFile [Feature] Support file_client_args in LoadImageFromFile Dec 9, 2021
@ly015 ly015 merged commit 6c9ef32 into dev-0.22 Dec 9, 2021
@jin-s13 jin-s13 deleted the loadimage branch December 16, 2021 08:09
ly015 pushed a commit to ly015/mmpose that referenced this pull request Dec 17, 2021
ly015 pushed a commit that referenced this pull request Jan 4, 2022
ly015 pushed a commit that referenced this pull request Jan 5, 2022
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev-0.22@4297d1e). Learn more about missing BASE report.

Files Patch % Lines
mmpose/datasets/pipelines/loading.py 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             dev-0.22    #1076   +/-   ##
===========================================
  Coverage            ?   83.35%           
===========================================
  Files               ?      196           
  Lines               ?    15156           
  Branches            ?     2739           
===========================================
  Hits                ?    12634           
  Misses              ?     1827           
  Partials            ?      695           
Flag Coverage Δ
unittests 83.30% <62.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants