Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename typing.py to typing_utils.py #2548

Merged
merged 8 commits into from
Feb 1, 2023
Merged

Conversation

zccjjj
Copy link
Contributor

@zccjjj zccjjj commented Feb 1, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix the bug in running collect_evn.py. #2547

Modification

Rename typing.py to typing_utils.py

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 83.41% // Head: 83.40% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (fe7dd3f) compared to base (698dee9).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head fe7dd3f differs from pull request most recent head 4e7e131. Consider uploading reports for the commit 4e7e131 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2548      +/-   ##
===========================================
- Coverage    83.41%   83.40%   -0.02%     
===========================================
  Files          145      145              
  Lines         8510     8510              
  Branches      1274     1274              
===========================================
- Hits          7099     7098       -1     
- Misses        1197     1198       +1     
  Partials       214      214              
Flag Coverage Δ
unittests 83.40% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/utils/typing_utils.py 100.00% <ø> (ø)
mmseg/utils/__init__.py 100.00% <100.00%> (ø)
mmseg/utils/misc.py 87.50% <100.00%> (ø)
mmseg/datasets/transforms/transforms.py 90.40% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng
Copy link
Collaborator

Thanks for your contribution!

Would you like to share the error log, as I didn't meet any errors when run python ./mmseg/utils/collect_env.py.

@zccjjj
Copy link
Contributor Author

zccjjj commented Feb 1, 2023

Thanks for your contribution!

Would you like to share the error log, as I didn't meet any errors when run python ./mmseg/utils/collect_env.py.

brench dev-1.x

Traceback (most recent call last):
  File "./mmseg/utils/collect_env.py", line 2, in <module>
    from mmengine.utils import get_git_hash
  File "/root/anaconda3/envs/mmlab2/lib/python3.7/site-packages/mmengine/__init__.py", line 3, in <module>
    from .config import *
  File "/root/anaconda3/envs/mmlab2/lib/python3.7/site-packages/mmengine/config/__init__.py", line 2, in <module>
    from .config import Config, ConfigDict, DictAction
  File "/root/anaconda3/envs/mmlab2/lib/python3.7/site-packages/mmengine/config/config.py", line 15, in <module>
    from typing import Any, Optional, Sequence, Tuple, Union
  File "/root/mmsegmentation/mmseg/utils/typing.py", line 3, in <module>
    from typing import Dict, List, Optional, Sequence, Tuple, Union
ImportError: cannot import name 'Dict' from 'typing' (/root/mmsegmentation/mmseg/utils/typing.py)

@MeowZheng MeowZheng merged commit ce63ccf into open-mmlab:dev-1.x Feb 1, 2023
@zccjjj zccjjj deleted the dev-1.x branch February 1, 2023 11:48
@zccjjj zccjjj restored the dev-1.x branch February 1, 2023 11:49
@zccjjj zccjjj deleted the dev-1.x branch February 1, 2023 11:49
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
## Motivation

Fix the bug in running ```collect_evn.py```. open-mmlab#2547 

## Modification

Rename typing.py to typing_utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants