Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.x: wrappers: install the pkgconfig scripts better #12628

Merged

Conversation

jsquyres
Copy link
Member

Whenever we're installing binaries, install the pkgconfig scripts. Remove the AM conditional logic from deep inside other conditionals and just make it standalone at the top of the file (because installing the .pc files really does not depend on whether we're installing the script wrappers or binary wrappers).

Signed-off-by: Jeff Squyres jeff@squyres.com
(cherry picked from commit 25bf9e4)

This is the v5.0.x PR corresponding to main PR #12627
Also fixes #12609

Whenever we're installing binaries, install the pkgconfig scripts.
Remove the AM conditional logic from deep inside other conditionals
and just make it standalone at the top of the file (because installing
the .pc files really does not depend on whether we're installing the
script wrappers or binary wrappers).

Signed-off-by: Jeff Squyres <jeff@squyres.com>
(cherry picked from commit 25bf9e4)
@jsquyres jsquyres requested a review from bwbarrett June 18, 2024 14:13
@jsquyres jsquyres linked an issue Jun 18, 2024 that may be closed by this pull request
@github-actions github-actions bot added this to the v5.0.4 milestone Jun 18, 2024
@wenduwan wenduwan merged commit a5258f0 into open-mpi:v5.0.x Jun 19, 2024
13 checks passed
@jsquyres jsquyres deleted the pr/v5.0.x/install-pkg-config-scripts-better branch July 6, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgconfig files not installed with --enable-script-wrapper-compilers
3 participants