Remove storage calls from local.Driver.alterModules

[davis-haba]

Remove UpsertPolicy/DeletePolicy from local.driver.altermodules

#156

[willbeason]

FYI - you'll need to add DCO for this commit (the failure has the exact command to fix it for this).

In the long term, you may want to set up a commit hook that automatically appends the signature line so you never forget DCO.

[davis-haba]

Thanks @willbeason. I updated the commit with the signature.

[willbeason]

Great!

[sozercan]

@davis-haba looks like unit tests are failing

[codecov-commenter]

Codecov Report

Merging #184 (ac8fe07) into master (b0196c3) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   45.70%   45.56%   -0.15%     
==========================================
  Files          59       59              
  Lines        2866     2853      -13     
==========================================
- Hits         1310     1300      -10     
+ Misses       1309     1307       -2     
+ Partials      247      246       -1     

Flag	Coverage Δ
unittests	45.56% <ø> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...works/constraint/pkg/client/drivers/local/local.go	64.66% <0.00%> (-0.49%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0196c3...ac8fe07. Read the comment docs.

[davis-haba]

@davis-haba looks like unit tests are failing

Thanks @sozercan. The tests were failing due to a test which mocked storage errors in local.driver.PutModule. Since we no longer write to storage during PutModule, I deleted the test.

[willbeason]

Merging. I'll update my current test PR in gatekeeper so it includes these changes, to see if it catches any problems.