Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Content-Type header for external_data request #192

Merged

Conversation

mrjoelkamp
Copy link
Contributor

@mrjoelkamp mrjoelkamp commented Jan 31, 2022

Fixes #191

Summary

  • Set Content-Type header for external_data request

cc: @sozercan

Signed-off-by: Joel Kamp joel.kamp@invitae.com

Signed-off-by: Joel Kamp <joel.kamp@invitae.com>
@codecov-commenter
Copy link

Codecov Report

Merging #192 (523bf7e) into master (4ee2501) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   46.84%   46.82%   -0.02%     
==========================================
  Files          59       59              
  Lines        2818     2819       +1     
==========================================
  Hits         1320     1320              
- Misses       1254     1255       +1     
  Partials      244      244              
Flag Coverage Δ
unittests 46.82% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...works/constraint/pkg/client/drivers/local/local.go 64.46% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee2501...523bf7e. Read the comment docs.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 0f61a46 into open-policy-agent:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] external_data http request doesn't set Content-Type header
5 participants