Add audit to demo #116
Merged
Add audit to demo #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
reviewed
May 15, 2019
demo/agilebank/demo.sh
Outdated
| @@ -100,6 +100,16 @@ echo | |||
|
|
|||
| pe "kubectl get k8sbannedimagetags -oyaml" | |||
There was a problem hiding this comment.
k8sbannedimagetags shows audit results (and mostly exists to show the audit results). Is there something specific we're trying to solve with the extra commands?
There was a problem hiding this comment.
The k8sbannedimagetags example did not result in any violations (at least not in my test cluster) and we didnt create any deployment with latest tag images in the demo. Hence I added some thing that gives us violations.
maxsmythe
reviewed
May 15, 2019
maxsmythe
approved these changes
May 16, 2019
| @@ -88,19 +85,13 @@ echo | |||
| NO_WAIT=true | |||
| p "All is well with the world, until the big outage. The bank is down for hours." | |||
| read | |||
| p "We must never again use the :latest tag in production!" | |||
| p "We had no idea there were resources in the cluster without resource limits. Now they are causing issues in production!" | |||
| echo | |||
| NO_WAIT=false | |||
|
|
|||
| echo "===== ENTER admin =====" | |||
There was a problem hiding this comment.
Move ENTER admin above "We had no idea there were ..."
demo/agilebank/demo.sh
Outdated
|
|
||
| pe "kubectl get k8sbannedimagetags -oyaml" | ||
| echo | ||
| read | ||
| NO_WAIT=true |
There was a problem hiding this comment.
We can leave NO_WAIT=true until we switch back to actual shell input
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.