-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo templates to the constraint template library #205
Add demo templates to the constraint template library #205
Conversation
Signed-off-by: Max Smythe <smythe@google.com>
6172ef8
to
9680d66
Compare
Signed-off-by: Max Smythe <smythe@google.com>
e509f4d
to
b9c3b0b
Compare
Signed-off-by: Max Smythe <smythe@google.com>
nit: To be consistent with stuff already in |
Signed-off-by: Max Smythe <smythe@google.com>
Done. Note I think the library directory structure may need to change for the permanent repo. There are a few problems. It's not clear who this library is intended for, admins or constraint developers. This is a problem in itself, but there are problems with the structure as-is depending on the audience. If admins:
If constraint developers:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Regarding the library directory structure, let's discuss this as a group to get more feedback. |
LMK if you want to merge this before or after the directory update. |
Per our group discussion, maybe rename the folder |
Signed-off-by: Max Smythe <smythe@google.com>
SGTM, renaming to |
Signed-off-by: Max Smythe smythe@google.com