Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch manager should ignore unrecognized groups #263

Merged

Conversation

maxsmythe
Copy link
Contributor

This will fix cases where constraints fail to be enforced and/or finalizers fail to be removed when there is a watch on a non-existent group and the resource expected to be enforced/cleaned-up are not currently watched.

Signed-off-by: Max Smythe smythe@google.com

Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe maxsmythe requested a review from ritazh October 15, 2019 03:12
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit ac5fba9 into open-policy-agent:master Oct 17, 2019
@maxsmythe maxsmythe deleted the handle-invalid-watch-group branch December 12, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants