Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject namespace as part of the request. #344

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Inject namespace as part of the request. #344

merged 3 commits into from
Dec 18, 2019

Conversation

maxsmythe
Copy link
Contributor

Fixes #232

Signed-off-by: Max Smythe smythe@google.com

sozercan
sozercan reviewed Dec 11, 2019
View reviewed changes
pkg/webhook/policy.go Outdated Show resolved Hide resolved
@maxsmythe
Inject namespace as part of the request.
2cdefc8 
Fixes open-policy-agent#232

Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe
Run goimports
9c0a46d 
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe
Copy link
Contributor Author

@sozercan Any other comments, or G2G?

@maxsmythe
Copy link
Contributor Author

@sozercan ping

sozercan
sozercan approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about the delay, lgtm

@maxsmythe maxsmythe merged commit d6bf4bf into open-policy-agent:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inject Namespaces Live as Part of the Request
2 participants
@maxsmythe @sozercan