Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface decision log errors via status API #5637

Closed
ashutosh-narkar opened this issue Feb 7, 2023 · 2 comments · Fixed by #5732 or #5797
Closed

Surface decision log errors via status API #5637

ashutosh-narkar opened this issue Feb 7, 2023 · 2 comments · Fixed by #5732 or #5797
Labels
feature-request runtime

Comments

@ashutosh-narkar
Copy link
Member

What is the underlying problem you're trying to solve?

Currently while processing decision logs, any errors that are encountered are logged. But these errors are not included in status updates which can be useful for the control plane to determine if OPA is having any issues while processing, uploading logs etc.

Describe a "Good Enough" solution

Include decision log plugin errors in status updates.
ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Mar 7, 2023
@ashutosh-narkar
plugins: Surface decision log errors via status API
897d0ed 
Currently errors encountered during decision log uploads
are logged. This change now includes these errors as
part of status updates  which can be useful for the control plane
to determine if OPA is having any issues while processing, uploading logs etc.

Fixes: open-policy-agent#5637

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar ashutosh-narkar mentioned this issue Mar 7, 2023
Merged
ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Mar 7, 2023
@ashutosh-narkar
plugins: Surface decision log errors via status API
a7d4b2a 
Currently errors encountered during decision log uploads
are logged. This change now includes these errors as
part of status updates  which can be useful for the control plane
to determine if OPA is having any issues while processing, uploading logs etc.

Fixes: open-policy-agent#5637

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Mar 7, 2023
@ashutosh-narkar
plugins: Surface decision log errors via status API
91d1234 
Currently errors encountered during decision log uploads
are logged. This change now includes these errors as
part of status updates  which can be useful for the control plane
to determine if OPA is having any issues while processing, uploading logs etc.

Fixes: open-policy-agent#5637

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Mar 7, 2023
@ashutosh-narkar
plugins: Surface decision log errors via status API
e186242 
Currently errors encountered during decision log uploads
are logged. This change now includes these errors as
part of status updates  which can be useful for the control plane
to determine if OPA is having any issues while processing, uploading logs etc.

Fixes: open-policy-agent#5637

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar ashutosh-narkar added distribution Issues related to the bundle plugin runtime and removed distribution Issues related to the bundle plugin labels Mar 7, 2023
ashutosh-narkar added a commit that referenced this issue Mar 8, 2023
@ashutosh-narkar
plugins: Surface decision log errors via status API
c4efb26 
Currently errors encountered during decision log uploads
are logged. This change now includes these errors as
part of status updates  which can be useful for the control plane
to determine if OPA is having any issues while processing, uploading logs etc.

Fixes: #5637

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar
Copy link
Member Author

In #5732 we updated the decision log plugin to surface errors via the Status API. There are some other events like encoder errors and log drops due to buffer size limits for eg. are logged but there is no metric or status entry from them. We should capture those as well.

@ashutosh-narkar
Copy link
Member Author

Also we seem to be adding the global metric registry under the decision log status update here. This should not be needed as the status plugin already reports those.

ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Mar 30, 2023
@ashutosh-narkar
plugins: Surface more decision log errors via status API
9ba19f3 
Previously in open-policy-agent#5732 we updated the decision log plugin to
surface errors via the Status API. However in that change
certain events like encoder errors and log drops due to
buffer size limits had no metrics associated with them.
This change adds more metrics for these events so that they
can be surfaced via the Status API.

Fixes: open-policy-agent#5637

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar ashutosh-narkar mentioned this issue Mar 30, 2023
Merged
ashutosh-narkar added a commit that referenced this issue Mar 30, 2023
@ashutosh-narkar
plugins: Surface more decision log errors via status API
c858397 
Previously in #5732 we updated the decision log plugin to
surface errors via the Status API. However in that change
certain events like encoder errors and log drops due to
buffer size limits had no metrics associated with them.
This change adds more metrics for these events so that they
can be surfaced via the Status API.

Fixes: #5637

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request runtime
Projects
Open Policy Agent
Status: Done
Milestone
No milestone
1 participant
@ashutosh-narkar